Remove Unnecessary Non-Terminal Key checks #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #248 +/- ##
==========================================
+ Coverage 92.23% 92.78% +0.54%
==========================================
Files 42 45 +3
Lines 2564 3255 +691
Branches 298 300 +2
==========================================
+ Hits 2365 3020 +655
- Misses 195 230 +35
- Partials 4 5 +1 ☔ View full report in Codecov by Sentry. |
blockgroot
force-pushed
the
feat/remove-NT-key-checks
branch
4 times, most recently
from
0f7fc7d to
675199a
Compare
blockgroot
force-pushed
the
feat/remove-NT-key-checks
branch
from
675199a to
896ae0c
Compare
| @@ -59,6 +59,7 @@ contract PermissionlessNodeRegistry is | |||
| //mapping of operator address with nodeELReward vault address | |||
| mapping(uint256 => address) public override nodeELRewardVaultByOperatorId; | |||
| mapping(uint256 => address) public proposedRewardAddressByOperatorId; | |||
| uint256 public maxKeyPerOperator; | |||
| * @notice update the max validator per operator value | ||
| * @dev only `MANAGER` role can update | ||
| */ | ||
| function updateMaxKeyPerOperator(uint256 _maxKeyPerOperator) external { |
There was a problem hiding this comment.
Please get this reviewed by @batphonghan as well.
batphonghan
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.